Development of v0.2.2 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [if_not_else_linter] In a simple if/else statement, prefer `if (A) x else y` to the less-readable `if (!A) y else x`
- [scalar_in_linter] Use == to match length-1 scalars, not %in%. Note that == preserves NA where %in% does not
- [unreachable_code_linter] Code inside a conditional loop with a deterministically false condition should be removed.
- [implicit_assignment_linter] Avoid implicit assignments in function calls. For example, instead of `if (x <- 1L) { ... }`, write `x <- 1L; if (x) { ... }`
- [paste_linter] Construct file paths with file.path(...) instead of paste(..., sep = "/"). If you are using paste(sep = "/") to construct a date, consider using format() or lubridate helpers instead. Note that paste() converts empty inputs to "", whereas file.path() leaves it empty.
…iable parameters - new argument "bind_params" (replacing deprecated "mukeys_unique") for single or multi-variable parameter injections - new argument "injection_format" to locate format string used to bind/inject values in parametrized queries - updated documentation and test cases
Previously, the condition `res[[k]] > 0` was true but `inherits(res[[k]], "try-error")` failed because res[[k]] was of length k - 1 if soilDB::SDA_query() returned NULL Now, we test if `res[[k]] >= k` before checking `inherits(res[[k]], "try-error")`
- new sqlQuote() which wraps its argument in single quote - this replaces shQuote() which returns double quotes on Windows OS; double quotes fail when querying soils data from NRCS SDA
- extract_topography_NEDUSA() now correctly extracts values from one layer if requested - previously, an erroneous check enforced at least two layers - updated example code and tests that extract from one layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.