forked from typelevel/scalacheck
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest rickynils/master #1
Open
shadaj
wants to merge
38
commits into
Duhemm:cross-native
Choose a base branch
from
shadaj:cross-native
base: cross-native
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test to count the frequency of selecting groups of 2 from 8 numbers. Not worth keeping, only useful for representing the defect. There may be a better long term test, but this isn't it. This one should be discarded in the long term.
The update of Gen.pick in a2100f6 should have selected elements with a uniform distribution, but used the wrong value for modulus when generating the next random number. The modulus should be the count, and not the number of values to pick. The code looks like the "reservoir sampling" technique, but just needs to generate a random number within the range of the current count of the collection, so that elements of the beginning of the list get greater weight than the end.
this is for Scala 2.13.0-M1 friendliness; older Scala.js versions weren't published for 2.13.0-M1
Scala.js version bump for master
Add Arbitrary[UUID]
Gen.pick defect
Avoid BootstrapMethodError errors during serialization
Bump sbt from 0.13.13 to 0.13.15
delete unused private method
upgrade scalajs to 0.6.19
Add Scala 2.13.0-M2 suppport
Added support to build on scala.js 1.0.0-M1
12 tasks
It's safe to sort only by the keys, because they are distinct. Fixes typelevel#356
Add Gen.product and Gen.tailRecM
Drop Ordering bound on the values in cogenMap
@Duhemm could you review this so that the original PR can be made ready for merge? Right now, Scala Native support in ScalaCheck is blocking scalatest/scalatest#1185. |
…stable_column_width Support for adjustable-width ConsoleReporter output
Fixes the type parameter in a call to arbitrary in a property
Add Gen.filterNot() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges in the latest master from rickynils/scalacheck and bumps the Scala Native version, which should make typelevel#337 ready for merge.