Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: shortcut for searching a new partner doesn't work #462

Closed
Dun-sin opened this issue Oct 18, 2023 · 3 comments · Fixed by #465
Closed

[BUG]: shortcut for searching a new partner doesn't work #462

Dun-sin opened this issue Oct 18, 2023 · 3 comments · Fixed by #465
Assignees
@aman44444
Labels
assigned bug Something isn't working frontend this issue requires knowlegde of frontend hacktoberfest Medium It's average in difficulty

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 18, 2023 •
edited
Loading

Description

It doesn't work because it's a browser shortcut too

Change the shortcut to ctrl + alt + n, You will find the code here

Whisper/client/src/components/Anonymous.jsx

Line 122 in ab1a0ca

useKeyPress(['n'], () => handleClose(true), ShortcutFlags.ctrl);

Screenshots

No response

Are you willing to work on this issue ?

None
@Dun-sin Dun-sin added bug Something isn't working Medium It's average in difficulty up for grabs anyone can ask to work on this hacktoberfest frontend this issue requires knowlegde of frontend labels Oct 18, 2023
@github-actions
Copy link
Contributor

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@aman44444
Copy link
Contributor

@Dun-sin can i work on this issue?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Oct 18, 2023

@Dun-sin can i work on this issue?

Sure, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck

@Dun-sin Dun-sin added assigned and removed up for grabs anyone can ask to work on this labels Oct 18, 2023
@aman44444 aman44444 mentioned this issue Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aman44444 aman44444

Labels
assigned bug Something isn't working frontend this issue requires knowlegde of frontend hacktoberfest Medium It's average in difficulty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added shortcut for searching a new partner aman44444/Whisper
2 participants
@Dun-sin @aman44444