Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Refactored Code That used socket methods #323

Merged
merged 7 commits into from
Sep 30, 2023

Conversation

govardhanshah456
Copy link
Contributor

Fixes Issue

**My PR closes #310 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Made Separate Definitions for Event Listeners and Event Emitters.
  • Replaced them in all the files with the newly made definitions.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

  • I had tried to make a common constants.js file but for that I had to define a separate ES-Lint Configuration only for that single file, so I moved it to client and server older Respectively.

πŸ“· Screenshots

@vercel
Copy link

vercel bot commented Sep 28, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@govardhanshah456 govardhanshah456 changed the title feat : Refactored Code That used socket methods feat : added Refactored Code That used socket methods Sep 28, 2023
@govardhanshah456 govardhanshah456 changed the title feat : added Refactored Code That used socket methods feat: added Refactored Code That used socket methods Sep 28, 2023
server/constants.js Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 28, 2023 4:48pm

server/constants.js Outdated Show resolved Hide resolved
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,do you want me to merge it when hacotberfest starts?

@govardhanshah456
Copy link
Contributor Author

Looks good,do you want me to merge it when hacotberfest starts?

Yes, thanks

@Dun-sin Dun-sin merged commit 1d925c7 into Dun-sin:main Sep 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] [REFACTOR]: Move all socket events into constant variables
2 participants