Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nav proptype (#670) #674

Merged
merged 2 commits into from
Aug 19, 2024
Merged

chore: remove nav proptype (#670) #674

merged 2 commits into from
Aug 19, 2024

Conversation

damirgros
Copy link
Contributor

Fixes Issue

My PR closes #670

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Removed propTypes from NavBar.jsx.

The following two pieces of code have been removed:

import PropTypes from 'prop-types';

and

NavBar.propTypes = { 
 	className: PropTypes.string, 
 }; 

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

Removed import for proptypes.

πŸ“· Screenshots

Copy link

vercel bot commented Aug 19, 2024

@damirgros is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 5ea33e0 into Dun-sin:main Aug 19, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] remove proptype in nav.jsx
2 participants