-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching to a different iOS image loading library. #13
Comments
My (not requested ;)) vote goes to Kingfisher. |
What's the problem with SDWebImage ? What are the pros and cons of each library ? From my experience SDWebImage is a very good library to deal with image cache, it's also one of the oldest. Let's establish the pros and cons list of the most interesting solution first. Also what would be the advantage of rewriting the component from scratch ? |
The original post seems to be about improving the situation for developers of FastImage. As a potential FastImage user, the most important thing to me is performance. Wanted to share this performance comparison I ran across: https://github.com/kean/Image-Frameworks-Benchmark nuke looks pretty impressive |
@StevenMasini as noted by @psugihara some (important) cons of sdwebimage are reported in the original post. @psugihara I didn't know nuke... It seems great! Is it possible for you to run your benchmark using the version 5 of Kingfisher? |
@faxioman not my benchmark, just a user there too :) For clarification, I was noting that the cons in the OP are not at very compelling to me because as a user I'm completely abstracted from the underlying APIs. Performance + the API of FastImage itself are my concerns. |
Don't worry, I am not against changing or anything. Don't misunderstand me, I like to keep my mind open to alternatives. I just want to make sure this change worse it. At least we have a good list of alternatives to consider now.
|
Sorry I don't respond to stuff as quickly as I could. My work is primarily not React Native at the moment and I haven't had a lot of time for this. I think over the next few weeks I may have more. @StevenMasini These issues in SDWebImage do sometimes leak through into issues for FastImage, it's just that they don't come up that often. e.g.
I think in the common use case SDWebImage definitely performs well, and maybe the solution is trying to contribute to making it better, rather than trying to switch to something else. @psugihara Thanks for the link to that. So far all I've found is https://bpoplauschi.wordpress.com/2014/03/21/ios-image-caching-sdwebimage-vs-fastimage/ , which is probably outdated at this point, and I haven't had the time to look at benchmarking things myself. |
@DylanVann Indeed I don't use neither But maybe they could be fixed using SDWebImage. |
Hi, has there been any movement on this? |
All this strange behavior already been fixed via SDWebImage 5.0, react-native-fast-image already upgraded. And I’m the maintainer of this framework and found these old suck behavior really painful. If you have some more feature request, feel free to open https://github.com/SDWebImage/SDWebImage/issues. If it’s not hack or hard-coded to any business logic, I’ll always provide a solution. |
Although it's very performant and used in tons of applications the API for SDWebImage is sort of weird.
e.g. The API for prefetching:
Weird things:
e.g. The API for headers:
Weird things:
(The api of headersFilter does not allow that)
Maybe there's another native library we could use that's more straightforward than this.
The text was updated successfully, but these errors were encountered: