Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6645 Update OpenXML export data to excel sample #14914

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 30, 2024

Purpose

Update OpenXML export data to excel sample to export to xlsx file instead of csv file. Export to csv seems regressed from a couple versions before

OpenXMLExport_Data To Excel

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update OpenXML export data to excel sample to export to xlsx file instead of csv file

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.0.3 milestone Jan 30, 2024
@QilongTang QilongTang changed the title Update OpenXML export data to excel sample DYN-6645 Update OpenXML export data to excel sample Jan 30, 2024
@QilongTang QilongTang merged commit 10915c0 into RC3.0.3_master Jan 30, 2024
18 of 19 checks passed
@QilongTang QilongTang deleted the OpenXMLSample branch January 30, 2024 21:36
QilongTang added a commit that referenced this pull request Jan 30, 2024
QilongTang added a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant