Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker and CWL databases type "string" #23

Open
mberacochea opened this issue Aug 24, 2020 · 3 comments
Open

Docker and CWL databases type "string" #23

mberacochea opened this issue Aug 24, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mberacochea
Copy link
Member

Running the pipeline using docker is currently blocked by the databases paths being strings instead of Directory|File.

The paths change to string was required due to some issues with Toil and the EBI cluster.

We are currently working to fix this problem and make the pipeline fully compatible with docker. The current hacky workaround to this problem is to patch the docker.py file in CWL and add the databases' folder path hardcoded.

The patch only works for Toil[CWL] and cwltool.

Patch for docker.py.

self.append_volume(runtime, "<PATH to DBS>", "/data/databases", writable=False)
@mberacochea mberacochea added the bug Something isn't working label Aug 24, 2020
@mberacochea mberacochea self-assigned this Aug 24, 2020
@KateSakharova
Copy link
Contributor

@mberacochea Martin, it is possible to use several types for inputs
For example,

type: [ string, File ]

I think it will solve our problem without any significant changes :)

@mberacochea
Copy link
Member Author

Brilliant @KeteSakharova , I'll give that a try.

@KateSakharova
Copy link
Contributor

KateSakharova commented Sep 22, 2020

I'm trying to fix that in docker-databases-paths-fix branch but I bumped into similar issue like in common-workflow-language/cwltool#1285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants