Fix bug with PML in 2D when compiling with EB #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
changed the title
RemiLehe
changed the title
EZoni
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of WarpX, the PML field update is not done properly in 2D, if the code is compiled with EB support.
There are 2 bugs that are causing this, which are being fixed in this PR:
When calling the
ScaleEdgesfunction, we were passing an array of cellsizes that, in 2D, looked like{dx, dz, 0}while the function expected something of the form{dx, 0, dz}. This is now fixed by callingWarpX::CellSize(lev).The
ifcondition that ensures that the PML field is not updated in the EB was not implemented correctly. We now use the sameifcondition for the PML field as for the regular field:https://github.com/ECP-WarpX/WarpX/blob/development/Source/FieldSolver/FiniteDifferenceSolver/EvolveE.cpp#L174
Many thanks to @anecas1979 for finding this bug and helping with the debugging process!