Add thermalBC for particles #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
RemiLehe
reviewed
Mar 21, 2024
dpgrote
reviewed
Mar 26, 2024
dpgrote
reviewed
Mar 26, 2024
Co-authored-by: David Grote <dpgrote@lbl.gov>
RevathiJambunathan
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RemiLehe
reviewed
Mar 30, 2024
RemiLehe
reviewed
Mar 30, 2024
RemiLehe
approved these changes
Mar 30, 2024
RemiLehe
reviewed
Mar 31, 2024
Regression/Checksum/benchmarks_json/particle_thermal_boundary.json
Outdated
Show resolved
Hide resolved
RevathiJambunathan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redoing #4681
@RemiLehe added a PR to demonstrate thermal BC
This PR does the same, with some restructuring, and changes to API
Tested locally and ensured that the velocity distribution is Maxwellian (thermalized) even at the end of the simulation.
CI test is added to ensure that the particle energy does not increase by more than 2%
(if particle boundary is reflecting or thermal without "folding of the current density and charge", then the particle energy increase by more than 10% )