Add oneMKL FFT to AnyFFT wrapper for SYCL backend #5127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
mkl_fft
branch
2 times, most recently
from
be0c694
to
f78885f
Compare
ax3l
added
component: spectral
ax3l
reviewed
Aug 13, 2024
ax3l
approved these changes
Aug 14, 2024
ax3l
reviewed
Aug 14, 2024
ax3l
approved these changes
Aug 14, 2024
RemiLehe
pushed a commit
that referenced
this pull request
Oct 10, 2024
We do not need FFTW3 anymore to do FFTs on SYCL GPUs. Follow-up to #5127 X-ref: spack/spack#46765
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Oct 23, 2024
We do not need FFTW3 anymore to do FFTs on SYCL GPUs. Follow-up to ECP-WarpX#5127 X-ref: spack/spack#46765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: I did a 2d test Examples/Tests/langmuir/inputs_2d.
Unfortunately the results are wrong. The issue might be in the new FFT wrapper. But it could also be in somewhere else because we have not run much on Intel GPUs.It works now after explicitly setting strides in the forward domain.