-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DSMC reaction weight calculation #5135
Update DSMC reaction weight calculation #5135
Conversation
Signed-off-by: roelof-groenewald <regroenewald@gmail.com>
9e7956e
to
bd4666d
Compare
I reran the physics benchmark used to originally validate the DSMC implementation (comparing against the Turner 2013 MCC benchmark). The plots below show the results for the 1st case using different numbers of kinetic neutral particles: The results match expectation unless the number of neutral particles is too low (neutral density is much higher than plasma density in this problem so good statistics would require more neutral macro-particles than for ions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me.
This PR updates the DSMC scheme to use the updated reaction weight calculation described by @JustinRayAngus in #5047.
Still to do: