Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDMC.exe failed to create a shipyard file #868

Closed
Eventure-TCE opened this issue Feb 9, 2021 · 10 comments
Closed

EDMC.exe failed to create a shipyard file #868

Eventure-TCE opened this issue Feb 9, 2021 · 10 comments
Labels
FDev API Frontier Frontier's Fault upstream Requires an upstream fix

Comments

@Eventure-TCE
Copy link

Eventure-TCE commented Feb 9, 2021

Hello Athan,
I have to report an issue with EDMC.exe when using the -s parameter:
grafik

Here is the output as requested (with the -d parameter):
test.txt

And here is the log:
EDMC-debug.log

@Eventure-TCE Eventure-TCE added bug unconfirmed An unconfirmed bug labels Feb 9, 2021
@A-UNDERSCORE-D
Copy link
Contributor

Appears that something might be funky with the API, your test data doesnt the data we'd expect for the shipyard export, Ill let @Athanasius double check that though

@Athanasius
Copy link
Contributor

Yup, that lastStarport has no ships key at all. Are you sure it doesn't only have modules, no ships for sale ?

@Athanasius Athanasius added FDev API Frontier Frontier's Fault and removed bug labels Feb 9, 2021
@Eventure-TCE
Copy link
Author

Eventure-TCE commented Feb 9, 2021

Please check EDDB: https://eddb.io/station/2364
Also, the Test.txt contains a service info: "shipyard": "ok"

@Athanasius
Copy link
Contributor

Yes, but that's not what your CAPI data is saying. We can't give you data that the Frontier API is failing to pass back.

A relevant EDDB-stored EDDN message is https://ross.eddb.io/eddn/log/648294859 - which does indeed show ships for sale. EDMC.exe -s is only using CAPI data, not the journal. The whole of EDMC.exe is designed to only query the CAPI for such data (it does load the latest Journal it finds so as to set some state). There's no way to get EDMC.exe to react to the Cmdr opening the shipyard screen which would cause journal data for it to be written.

@Eventure-TCE
Copy link
Author

Eventure-TCE commented Feb 9, 2021

That's true, but we got the data as long as I can think.
So do you saying, the shipyard info is not longer available for all stations at the CAPI data, beside the file export of ED, when a player opens the shipyard screen in game?

@Athanasius
Copy link
Contributor

This is, at least, a bug on Frontier's side. If it's not a wholesale change by them. It will need more investigation (i.e. check more stations, including ones that absolutely always have ships for sale like Jameson Memorial).

We could possibly provide a method to output the desired information from the Journal if it's actually available (the Cmdr needs to have opened the screen, and have done so for the latest docked station).

@Eventure-TCE
Copy link
Author

The shipyard data isn't available at the journal by now, only at the created file called 'Shipyard.json', so I guess we have to wait and maybe report the issue to Frontier, if we have tested it with some more stations.

TCE automatically reads the file, if it was updated. So it is not required to provide support for TCE in that case.

Thanks for your help and work and please post an update here, if you got a new info about. Will do the same.

@Athanasius
Copy link
Contributor

I've taken the trip out to Gilliland Ring myself and have reproduced the issue. The RAW (from my own code, not EDMC) output from the CAPI for the /shipyard endpoint is attached.

Athanasius-shipyard-2020211-00_LTT 1798_Gillland Ring.json.txt

Literally "shipyard":"ok" in the services list, but no sign at all of the ships list. In-game I'm looking at the absolutely available (so not closed due to some BGS state, station damage or the like) shipyard:

LTT 1798_Gillland Ring_Shipyard

@Athanasius
Copy link
Contributor

And it turns out we'd already found this issue some time back, see https://discord.com/channels/164411426939600896/251742967927144449/736960475090256013 (EDCD Discord, #edmc channel)

@Athanasius
Copy link
Contributor

If you want to add reproductions to the issue I opened: https://issues.frontierstore.net/issue-detail/18441

@Athanasius Athanasius removed the unconfirmed An unconfirmed bug label Feb 11, 2021
@Athanasius Athanasius added the upstream Requires an upstream fix label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FDev API Frontier Frontier's Fault upstream Requires an upstream fix
Projects
None yet
Development

No branches or pull requests

3 participants