Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the bot to build for specific CVMFS repo #42

Open
trz42 opened this issue Oct 10, 2022 · 2 comments
Open

Enable the bot to build for specific CVMFS repo #42

trz42 opened this issue Oct 10, 2022 · 2 comments

Comments

@trz42
Copy link
Contributor

trz42 commented Oct 10, 2022

Currently, the bot's build target CVMFS repository is the default pilot.eessi-hpc.org (as configured in the build container) or any other repository that is configured via the pull request of the software layer. While this works well, it is not so straightforward to build one PR for another repository (e.g., for test purposes). Instead of configuring the target repository via a pull request, the bot's configuration could define target repositories and all necessary customisations. Then, the bot could work as follow to set up a build job:

  1. Obtain PR content.
  2. Apply changes defined in bot's configuration (the bot could have a default target which does not apply any changes to the PR content ... this would allow that also on the side of the PR one could still built for any repository).
  3. Submit job.
@boegel
Copy link
Contributor

boegel commented Oct 10, 2022

Ideally this also covers building and deploying software for something that is not a CVMFS repository at all, could be just an NFS shared filesystem.

I think the bot should be refactored so that is isn't actually aware for what filesystem/repo it is building software.

It should:

  • use a script named bot-build.sh to run the build phase
  • use a script named bot-test.sh to run the test phase
  • use a script named bot-deploy.sh to run the deploy phase

That way, everything that is specific would be in those scripts, and the bot is only aware of the different phases (build-test-deploy), not of how those are run exactly.

The job script in the bot repository, most of the logic should actually be in the bot-build.sh script that comes from the EESSI/software-layer GitHub repo (in the context of EESSI).

edit: separate issue for this: #126

@boegel
Copy link
Contributor

boegel commented Jan 12, 2024

@trz42 This is done, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants