-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inhibit Autocalibration capability #134
Comments
Hi, Yeah this was my idea... Now that I know that some people use jumpers it's definitely a problem. |
Do you mind trying adding this line of code in main.c ? When the board is ON, if the button is pressed or you put a jumper for flashing, it will not enter auto-calibration as the button won't be released. (no change here ) |
Thanks for the input....but for me it is not a strong enough inhibit Here is what i did config.h added these defines to default section //Auto calibration defaults are off ... change if you want to auto calibrate your ADC inputs or adjust current and speed ******** IN poweroffPressCheck i added to your if tests ***********
Double press: Adjust Max Current, Max Speed
See what you think |
From @RoboDurden issue #133
"And the good old cmd1 and cmd2 are turned into
InputStruct input1[INPUTS_NR] = { {0, 0, 0, PRI_INPUT1}, {0, 0, 0, AUX_INPUT1} };
InputStruct input2[INPUTS_NR] = { {0, 0, 0, PRI_INPUT2}, {0, 0, 0, AUX_INPUT2} };"
I must confess @RoboDurden has a good point here... I ran into similar debugging headaches because of this complexity. As a controls engineer I like the inputs to be readily visible , simple and easy to understand in Main.c.
I too inadvertently had a zero output from the auto calibration. I thought I was ok because I selected type 2 ADC since I am using the ADC to drive the motors as servos and also don't want auto cal.
But I may be mistaken, seems an auto cal is always performed if the power pin is left in for 5 seconds even if Type 2 is chosen.
Perhaps if you make a future mod in this area I would recommend giving the user the option to disable auto cal with a define. Or simply inhibit auto cal if type 1 or 2 are selected. If the user wants auto cal he selects type 3.
The reasoning for me at least is to prevent ignored inputs if during debug you simply left the power jumper in for a few seconds too long and didn't move the input. A zero command results and is committed to memory unless a full erase is done. I am working with a flying object and need to have very reliable inputs during testing and I know I might be distracted and jumper the power pin enough to enter auto cal.
The text was updated successfully, but these errors were encountered: