Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Action Name in Comment is Ignored in ABI Generation #5460

Closed
xJonathanLEI opened this issue Aug 28, 2018 · 1 comment
Closed

Action Name in Comment is Ignored in ABI Generation #5460

xJonathanLEI opened this issue Aug 28, 2018 · 1 comment

Comments

@xJonathanLEI
Copy link
Contributor

There is currently a bug in ABI generation with the program eosio-abigen. For a comment like:

@abi action hi

The action name hi is ignored for good. The tool simple takes the method name and put it in the name field of the action.

This is NOT an intended behavior as shown by the RegEx found in the file abi_generator.cpp:

(@abi (action)((?: [a-z0-9]+)*))

Obviously, there is supposed to be an optional trailing action name.

I've submitted a fix to the problem in the #5459 PR. Please review, thanks.

@xJonathanLEI
Copy link
Contributor Author

PR is approved. Closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant