This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
New test to ensure require_recipient to generator is ignored #5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heifner
commented
Aug 27, 2018
heifner
commented
- New unittest to ensure require_recipient to the generator of notify is ignored.
unittests/api_tests.cpp
Outdated
| produce_blocks(1); | ||
|
|
||
| // test require_notice | ||
| auto scope = std::vector<account_name>{N(testapi)}; |
There was a problem hiding this comment.
Is this actually used?
unittests/api_tests.cpp
Outdated
|
|
||
| // test require_notice | ||
| auto scope = std::vector<account_name>{N(testapi)}; | ||
| auto test_require_notice = [this](auto& test, std::vector<account_name>& scope){ |
There was a problem hiding this comment.
Does the lambda actually get you anything here? If not simplify it and just make it part of the method.
brianjohnson5972
approved these changes
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.