This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Port v1.2.4 and v1.2.5 #5720
Merged
Port v1.2.4 and v1.2.5 #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply all pending incoming transactions, even if not producing.
Really Bad Things can happen if multiple keosd are using the same wallet directory simultaneously. Like, loss of keys. Make a trivial locking mechanism so that this is prevented.
Trivial wallet directory locking for keosd
4904 add hint if launcher fails, more reliable port available check
"eosio_uninstall.sh --full" to delete directories with configs
The location of chainbase's mlock() is erroneously only encountered when the DB is constructed. Subsequent uses of a DB would not attempt a mlock(). Fix the location of this call. Also locking of the metadata was added.
(chainbase sync) Fix chainbase's mlock() to work on subsequent launches
fix abi serialization exception in get block
fix ambiguous command line option for filter-on/out
bump version to 1.2.4
Version 1.2.4
binaryen & softfloat libs are built within the main eos repo as git submodules
Unapplied transactions were only being pruned in a few instances: - when an HTTP RPC request was made to the node, the node would persistently attempt to apply that transaction until it was done OR expired, cleaning it up appropriately - when a Producer attempts to produce a block, it would apply as many unapplied transactions as it could, cleaning them up appropriately This means that relay nodes which never produce would also never prune the unapplied list. We now have 4 phases: Phase 1) [If not a producing node] prune all unapplied transactions that are not "persisted" due to being directly received over HTTP RPC Phase 2) [If potentially producing] prune all unapplied transactions that expired Phase 3) [If not "read only"] attempt application of all unapplied transactions that are "persisted" due to being directly received over HTTP RPC Phase 4) [If producing the next block] attempt application of all remaining unapplied transactions Each of these phases potentially prunes. Phases 1 & 2 are the new phases that cover P2P relays Additionally, Read-only nodes were never pruning the unapplied transactions. As they will never have need of them, nodes configured in this mode will unilaterally drop all unapplied transactions However, a p2p relay node neither producers no accepts the transactions
… no unapplied transactions
…es are accounted for it is pretty simple to call out the one case where we can avoid fetching it explicitly
The mlock code was effectively inactive until 1.2.4. Enabling it has caused some unexpected support fallout. Remove it for now until a better solution is implemented in the future; performance will effectively be no worse than pre 1.2.4
Remove unneeded libs from docker build
(chainbase sync) Remove chainbase mlock()
Fix unchecked unapplied transaction growth on relays
bump version to 1.2.5
Release 1.2.5
heifner
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.