Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update Sanitizers Pipeline ctest command #6135

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

prattj
Copy link
Contributor

@prattj prattj commented Oct 24, 2018

Change Description

Updated the ctest command to always return true for the undefined sanitizer and address sanitizer command steps in the buildkite sanitizers pipeline. Failure of this step is not critical. The pertinent sanitizer error information is being captured as a build artifact sanitizer log.

Consensus Changes

None.

API Changes

None.

Documentation Additions

None.

@wanderingbort
Copy link
Contributor

Looks ok to me but, I'd prefer the official review from someone more in-domain, paging @zreyn ?

@zreyn
Copy link
Contributor

zreyn commented Oct 26, 2018

Yup, this is good. The outcome of the tests don't matter much for this. We care about the tests executing the code paths so that the sanitizers can do the runtime analysis. The tests that assert time will frequently fail because the sanitizers incur a performance penalty, but we don't want the pipeline to appear broken when it's doing what we want.

@zreyn zreyn merged commit 1fb991b into develop Oct 26, 2018
@prattj prattj deleted the prattj/buildkite-sanitizers-return-true branch October 26, 2018 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants