This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
support reverse iteration & show RAM payer in get table (#6216 #6271) #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests to tests/get_table_tests.cpp
for this new functionality.
@@ -269,6 +269,7 @@ class read_only { | |||
string key_type; // type of key specified by index_position | |||
string index_position; // 1 - primary (first), 2 - secondary index (in order defined by multi_index), 3 - third index, etc | |||
string encode_type{"dec"}; //dec, hex , default=dec | |||
bool reverse = false; // from upper to lower |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be optional to support older clients.
taokayan
changed the title
support reverse iteration in get table (#6216)
support reverse iteration & show RAM payer in get table (#6216)
Nov 8, 2018
taokayan
changed the title
support reverse iteration & show RAM payer in get table (#6216)
support reverse iteration & show RAM payer in get table (#6216 #6271)
Nov 8, 2018
…on of upper_bound
…verse iteration to get_table_by_scope
I pushed some changes to account for the changed definition of |
Hey guys, I'm really looking forward to getting this merged in. |
heifner
approved these changes
Nov 19, 2018
This was referenced Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6216 #6271
Change Description
API Changes
RPC call: get_table_rows (cleos get table)
RPC call: get_table_by_scope (cleos get scope)
Documentation Additions
new parameters for get table rows:
-r,--reverse Iterate in reverse order (default: false)
--show-payer show RAM payer (default: false)
new parameter for get table by scope:
-r,--reverse Iterate in reverse order (default: false)
Command example
find the bid name with the lowest bid:
to show all bid names from lowbid to highbid, with RAM payer information