Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Net plugin optimizations #6464

Merged
merged 27 commits into from
Dec 14, 2018
Merged

Net plugin optimizations #6464

merged 27 commits into from
Dec 14, 2018

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Dec 11, 2018 •
edited
Loading

Change Description

Optimizations:

  • Minimize packed_transaction copies
  • Remove calls to get/find_plugin<chain_plugin> as lookup is surprisingly expensive
  • Provide more efficient sha256_less for id lookups

net_plugin:

  • Remove large_msg_notify and associated code as not used

Consensus Changes

None

API Changes

  • No changes to net_plugin wire protocol
  • Command line option max-implicit-request is removed. It was effectively ignored before.
  • signal accepted_transaction
    -- transaction_metadata packed_trx changed from packed_transaction to packed_transaction_ptr

Documentation Additions

  • Command line option max-implicit-request is removed. It was effectively ignored before.

None

@heifner
Do not broadcast block if peer lib is larger than block number
d381ec0
@heifner
Provide more efficient sha256_less
e845204
@heifner
Simply by removing unused large_msg_notify
2a32ee4
@heifner
Remove unused node_transaction_state.packed_txn
0594dd5
@heifner
Store serialized transaction as shared_ptr to minimize copies
e44f205
@heifner
Not possible for serialized_txn to be empty
28301f2
@heifner
Remove find_plugin overhead
f403da8
@heifner
Minimize shared_ptr copies
2678b5e
@heifner
Use sha256_less for all sets/maps with ids
ac374bb
@heifner
Add explicit constructors
7bcdcbc
@heifner
Add accept_transaction that takes a packed_transaction_ptr to avoid copy
de9742e
@heifner
Pass id and packed_transaction by const& since never moved
7923af9
@heifner
Remove copy assignment operator. Remove used std::move.
b4ad4a3
@heifner
Minimize packed_transaction copies. Store packed_transaction_ptr in t…
cfc3a85 
…ransaction_metadata.
@heifner
Cache chain_plugin lookup
8109f0a
@heifner
Update tester for transaction_metadata packed_transaction_ptr
a0f7ae0
@heifner
Remove packed_tansaction to net_message copy
81502d2
@heifner
Remove unused constructor
86e581a
@heifner
Explicitly disable copy/move construction
bd3b208
@heifner
Remove inflight update of node_transaction_state as it is not needed
e9e9fe0
@heifner
Remove connections for unused signals that only logged
f3255af
@heifner
Fix sync check for lib
52a6f19
@heifner
Merge remote-tracking branch 'origin/net-plugin-opt' into optimize-ne…
deb8460 
…t-plugin
@heifner heifner mentioned this pull request Dec 11, 2018
Closed
@heifner heifner requested a review from arhag December 11, 2018 14:02
@heifner
Copy link
Contributor Author

heifner commented Dec 11, 2018

The test failures appear to be real. Investigating.

@heifner heifner mentioned this pull request Dec 11, 2018
Closed
@heifner
Copy link
Contributor Author

heifner commented Dec 11, 2018 •
edited
Loading

Reverting "fix sync check for lib" fixed the smoke test. Created issue #6466 for investigation. This PR now contains only optimizations and removal of dead code.

@heifner heifner mentioned this pull request Dec 12, 2018
Merged
arhag
arhag suggested changes Dec 14, 2018
View reviewed changes
libraries/chain/include/eosio/chain/transaction.hpp Show resolved Hide resolved
libraries/chain/include/eosio/chain/transaction_metadata.hpp Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Outdated Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Outdated Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Outdated Show resolved Hide resolved
@heifner heifner merged commit 45cd568 into develop Dec 14, 2018
@heifner heifner deleted the optimize-net-plugin branch December 14, 2018 18:32
ehsandarroudi added a commit to ehsandarroudi/eosfactory that referenced this pull request Jan 22, 2019
@ehsandarroudi
Fix unrecognised option 'max-implicit-request' error on startup
5e91b3b 
This option has been removed in EOS 1.6.0. See EOSIO/eos#6464
@ehsandarroudi ehsandarroudi mentioned this pull request Jan 22, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @arhag