[Bug] TAPOS validation fails for ref_block_num of 0

[zquestz]

Version of EOSJS
Latest

Describe the bug
There appears to be a bug in eos-api.ts where hasRequiredTaposFields returns false if ref_block_num is equal to 0. We noticed a failed transaction where the block number was 61931520. This caused refBlock.block_num & 0xffff in eosjs-serialize.ts to return 0 and then the subsequent transaction failed to get signed.

To Reproduce
Steps to reproduce the behavior:

1. Generate an unsigned transaction for a block where refBlock.block_num & 0xffff equals zero. This is any block divisible by 65536.
2. Try to sign the transaction
3. Watch the signing fail due to hasRequiredTaposFields returning false!

Expected behavior
The transaction is valid when ref_block_num is zero.

[zquestz]

The merged PR appears to fix the issue. Will you be cutting a new release soon with the fix?

[jeffreyssmith2nd]

I'm not sure of the release timeline at the moment, but you can use the @edge package on NPM to get the latest unreleased changes

[zquestz]

I'm not sure of the release timeline at the moment, but you can use the @edge package on NPM to get the latest unreleased changes

Is there a list of breaking changes between the latest release and what is available in the edge package? A changelog would be required so I can audit the changes and make sure there are no unintended side effects from switching versions...

[c0d3ster]

Closing this since the issue has been resolved with the last PR. @zquestz there are not any breaking changes since v20; however, the develop branch could have breaking changes merged in at any time. I would recommend version locking to this PR to test locally then use that version for production. The NPM version for the last PR is 20.0.1-1fed0be.0. Let us know if you have any other questions or concerns!