Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 18 #1173

Closed
nelsonni opened this issue Apr 20, 2023 · 1 comment
Closed

Upgrade to React 18 #1173

nelsonni opened this issue Apr 20, 2023 · 1 comment
Labels
dependencies Issues or updates to dependency files feature Feature requests or improvements

Comments

@nelsonni
Copy link
Member

nelsonni commented Apr 20, 2023

React 18 was released on March 29, 2022. There are several new features (including some breaking changes) including:

We should follow the official How to Upgrade to React 18 guide for upgrading to React 18. Additionally, reZach/secure-electron-template project already uses React 18 in a similar fashion to Synectic so we can leverage them as an example.

@nelsonni nelsonni added feature Feature requests or improvements dependencies Issues or updates to dependency files labels Apr 20, 2023
@nelsonni
Copy link
Member Author

Updated to using React 18's Client Rendering APIs (i.e. createRoot) in ae84053.

Updated testing suite to remove @testing-library/react-hooks and migrate renderHook imports directly from @testing-library/react in 4e20eaf. Per the A Note about React 18 Support message on the @testing-library/react-hooks README:

As part of the changes for React 18, it has been decided that the renderHook API provided by this library will instead be included as official additions to both react-testing-library (testing-library/react-testing-library#991) and react-native-testing-library (callstack/react-native-testing-library#923) with the intention being to provide a more cohesive and consistent implementation for our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or updates to dependency files feature Feature requests or improvements
Projects
None yet
Development

No branches or pull requests

1 participant