Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_io.concatenate()` may fail if extracted laison cube is scalar #1716

Closed
valeriupredoi opened this issue Sep 5, 2022 · 0 comments · Fixed by #1715
Closed

_io.concatenate()` may fail if extracted laison cube is scalar #1716

valeriupredoi opened this issue Sep 5, 2022 · 0 comments · Fixed by #1715
Assignees
Labels
bug Something isn't working iris Related to the Iris package

Comments

@valeriupredoi
Copy link
Contributor

Raised (inadvertently) by @bouweandela in this comment - it all happens in _io._concatenate_overlapping_cubes(cubes) - after extract_time() the resulting cube may be scalar - so iris concatenation fails due to scalar cubes not having dim_metadata attributes in iris._concatenate_CubeSignature class (they do, but they are empty lists).

Now. my idea would be this to be fixed in extract_time() directly, but for now I'll fix it in our concatenation, not to belly up other preprocessors that use extract_time().

Scalar cubes are PITAs!

Fixed in #1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iris Related to the Iris package
Projects
None yet
2 participants