Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERA5-Land cmorizer/fixes #855

Closed
katjaweigel opened this issue Nov 4, 2020 · 3 comments · Fixed by #879
Closed

ERA5-Land cmorizer/fixes #855

katjaweigel opened this issue Nov 4, 2020 · 3 comments · Fixed by #879
Assignees
Labels
enhancement New feature or request fix for dataset Related to dataset-specific fix files

Comments

@katjaweigel
Copy link
Contributor

katjaweigel commented Nov 4, 2020

Is your feature request related to a problem? Please describe.
At the moment, there is an "on the flight" cmorizer for ERA5 data. In principle it also works for ERA5-Land, but there are some issues:

  1. For ESMValCore: The fixes already existing for ERA5 are to a large extend also needed for ERA5-Land, I tested this for the variable pr (monthly) by simply copying
    esmvalcore/cmor/_fixes/native6/era5.py
    to
    esmvalcore/cmor/_fixes/native6/era5_land.py
    and it works, but there might be differences for other variables.
  2. For the ESMValTool: Would it make sense, to include an ERA5-Land example to esmvaltool/recipes/cmorizers/recipe_era5.yml or make an own esmvaltool/recipes/cmorizers/recipe_era5-land.yml?

Would you be able to help out?
Partly

@katjaweigel katjaweigel added the enhancement New feature or request label Nov 4, 2020
@katjaweigel katjaweigel added the fix for dataset Related to dataset-specific fix files label Nov 4, 2020
@valeriupredoi
Copy link
Contributor

@katjaweigel probably best to include the land bit in the existng recipe_era5.yml unles there are solid reasons why it should be separate; are the fixes needed for all the ERA5 variables? If so, we can use the All functionality for all vars 👍

@katjaweigel
Copy link
Contributor Author

katjaweigel commented Nov 11, 2020

I'm afraid the fixes are different, for different variables. For ERA5 there are already fixes for several variables in esmvalcore/cmor/_fixes/native6/era5.py, for ERA5-Land at least the fix there for pr is the same as for ERA5, but I'm not sure if this is true for the other variables.

@bouweandela
Copy link
Member

copying esmvalcore/cmor/_fixes/native6/era5.py to esmvalcore/cmor/_fixes/native6/era5_land.py and it works

Rather than copying the file, I would recommend importing the required classes from it

but there might be differences for other variables.

Yes, the main part of the work would probably be to carefully read the ERA5(land) documentation and see what is needed

For the ESMValTool: Would it make sense, to include an ERA5-Land example to esmvaltool/recipes/cmorizers/recipe_era5.yml or make an own esmvaltool/recipes/cmorizers/recipe_era5-land.yml?

I think both options are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants