Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native6, OBS6 and RAWOBS rootpaths to metoffice config-user.yml template, and remove temporary dir #2432

Merged
merged 5 commits into from
May 27, 2024

Conversation

alistairsellar
Copy link
Contributor

@alistairsellar alistairsellar commented May 22, 2024

Description

Add native6, OBS6 and RAWOBS rootpaths to metoffice config-user.yml template, and remove temporary dir. Linked Tool PR: ESMValGroup/ESMValTool#3613

Closes #2431

Link to documentation: https://esmvaltool--2432.org.readthedocs.build/projects/ESMValCore/en/2432/


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (88e53ac) to head (5eea3a3).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         246      246           
  Lines       14023    14023           
=======================================
  Hits        13254    13254           
  Misses        769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, cheers @alistairsellar - there is documentation about these repositories, right? 🍺

@alistairsellar
Copy link
Contributor Author

Thanks @valeriupredoi!

And good shout - there wasn't any documentation on the local MetO data pool yet. Now added to the Met Office ESMValTool sharepoint site.

@alistairsellar alistairsellar added this to the v2.11.0 milestone May 24, 2024
@valeriupredoi valeriupredoi added the enhancement New feature or request label May 27, 2024
@valeriupredoi valeriupredoi merged commit 8d3d366 into main May 27, 2024
6 checks passed
@valeriupredoi valeriupredoi deleted the 2431-metoffice-config-user branch May 27, 2024 12:34
chrisbillowsMO pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add native6, OBS6 and RAWOBS rootpaths to metoffice config-user.yml template, and remove temporary dir
2 participants