How do I find a pull request to review?

[bouweandela]

Since this was asked in our recent meeting of the @ESMValGroup/tech-reviewers, I'm adding the question here. Since I've had the question before, I'll also add to the answer I wrote in the documentation:

Please pick pull requests to review yourself based on your interest or expertise. We try to be self-organizing, so there is no central authority that will assign you to review anything. If someone knows you have expertise on a certain topic, they might request your review on a pull request.

Based on the outcome of the discussion here, we can update the text of course.

If you have some time to review a pull request but don't know where to start, please say so in this thread and I'll try to find you something suitable!

[bouweandela]

@ESMValGroup/esmvaltool-developmentteam To make it more easy to find a pull request that needs a review, I have started adding labels:

Technical reviews, to be done by @ESMValGroup/tech-reviewers:

• looking for technical reviewer
• in technical review
• approved by technical reviewer

Scientific reviews, to be done by @ESMValGroup/science-reviewers or other interested scientists:

• looking for scientific reviewer
• in scientific review
• approved by scientific reviewer

to mark where in the review process a pull request is. I have started applying the labels that I think are right for every pull request to all currently open pull requests, but please help me with this if I get it wrong. If anyone has ideas for better colors for the labels, please change them to something that looks nicer. I thought green made sense for labels containing the word approved.

More information about the review process can be found in the documentation.

@ESMValGroup/tech-reviewers Note that all tests on CircleCI and the readthedocs documentation build should be successful (green) and a minimal number of Codacy issues should be reported before a pull request can be marked as 'approved by technical reviewer', because if they are not green the technical reviewer needs to help the author of the pull request to get them green before passing the ball on to the scientific reviewer. Once the scientific review is done, the technical reviewer needs to check that the tests are still green and Codacy issues are minimal.