Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in diagnostic script for recipe_sea_surface_salinity #2641

Closed
sloosvel opened this issue Apr 27, 2022 · 1 comment · Fixed by #2642
Closed

Fixes in diagnostic script for recipe_sea_surface_salinity #2641

sloosvel opened this issue Apr 27, 2022 · 1 comment · Fixed by #2642

Comments

@sloosvel
Copy link
Contributor

Describe the bug
@portegam noticed that the computations in compare_salinity.py used in recipe_sea_surface_salinity are not entirely appropriate to compute the metrics needed in CMUG D5.4. He proposes the following changes:


line 119 (old code) >      corr = pearsonr(data, reference, ('month_number', 'year'))
line 119 (new code) >    corr = abs(climate_statistics(reference, 'mean')-climate_statistics(data, 'mean’))

line 124 (old code) >      [0.25, 0.5, 0.75], ["0.25", "0.5", "0.75"], color="grey", size=7)
line 124 (new code) >      [3, 6, 9], [“3", “6", “9"], color="grey", size=7)

line 154 (new code) >     f”Correlation comparison in diferent regions for "
line 154 (new code) >     f”Absolute bias comparison in diferent regions for “


@sloosvel
Copy link
Contributor Author

FYI @kserradell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant