Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anyway to speed up the evaluation? #6

Open
guohengkai opened this issue Nov 18, 2022 · 2 comments
Open

Is there anyway to speed up the evaluation? #6

guohengkai opened this issue Nov 18, 2022 · 2 comments

Comments

@guohengkai
Copy link

Hi,

Thank you for your awesome evaluation project. I'm trying to evaluate the local feature using your repo, but it is a bit slow to run one pass (https://github.com/cvg/pixel-perfect-sfm/blob/main/pixsfm/eval/eth3d/triangulation.py#L28). Is there any method to speed up the evaluation, like tuning some parameters or improving the implementation?

@puzzlepaint
Copy link
Contributor

It is very likely that the evaluation can be sped up when spending some effort on optimizing it. The first step would probably be to profile it, at the minimum a basic check to see whether the accuracy or the completeness evaluation is the slower one for your datasets, to see where the most time could likely be gained.

For the accuracy evaluation, the cell counts in this line and the line below it could be tuned with little effort:

const int kCellCountInclination = 1024;

For the completeness evaluation, maybe this data structure could be tuned or exchanged with some kind of volumetric storage for faster access / growing:

std::unordered_map<std::tuple<int, int, int>, CompletenessCell>

@guohengkai
Copy link
Author

Thank you. I will try them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants