Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFTW needed? #53

Closed
michael-petersen opened this issue Nov 3, 2023 · 2 comments
Closed

FFTW needed? #53

michael-petersen opened this issue Nov 3, 2023 · 2 comments
Assignees
@michael-petersen @The9Cat
Labels
bug Something isn't working

Comments

@michael-petersen
Copy link
Member

A test compilation where FFTW was accidentally not included seemed to suggest that cmake still needed FFTW_INCLUDE_DIRS. To be investigated...
@michael-petersen michael-petersen added the bug Something isn't working label Nov 3, 2023
@michael-petersen michael-petersen self-assigned this Nov 3, 2023
@The9Cat
Copy link
Contributor

The9Cat commented Sep 4, 2024 •
edited
Loading

FFTW is used by TransformFFT for the DFT computations in pyEXP and by gensph. We could switch off DFT computations and not compile gensph if fftw is not found. But I'm currently thinking that it might be better to require FFTW.

This bug has languished long enough. The easiest thing to do is require FFTW and close it out. Thoughts on this?

@The9Cat The9Cat self-assigned this Sep 4, 2024
@michael-petersen michael-petersen mentioned this issue Oct 16, 2024
Merged
@michael-petersen
Copy link
Member Author

This is addressed by #90. We haven't had any complaints about requiring FFTW, so I think this is an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-petersen michael-petersen

@The9Cat The9Cat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-petersen @The9Cat