Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Modifications #7

Open
1 of 5 tasks
cehanagan opened this issue Oct 3, 2023 · 0 comments
Open
1 of 5 tasks

Function Modifications #7

cehanagan opened this issue Oct 3, 2023 · 0 comments

Comments

@cehanagan
Copy link
Collaborator

cehanagan commented Oct 3, 2023

Suggested, low-priority tasks:

  • ts_from_mseed(): aside from documentation, make the "scale_factor" and "unit" parameters intuitive - they essentially serve the same functionality
  • event(event_id=): right now, the usgs catalogue is used. It might be useful to incorporate other catalogues. obspy has a read_events function that takes in links to quakeml (which I believe is standard to the IRIS DMC)
  • calc_hypocentral_dist(): Right now, the distance is calculated w/ pythagorous for the depth. This is approximately correct for short distances where curvature is negligible. It may be a good idea to include a separate calculation for epicentral distance - obsp also has a function, but a geopy wgs ellipsoid distance should suffice.
  • suggestion for the processing.py linear_trend_correction. Might be useful to make the name calculate_linear_trend. This is helpful for using the tab-complete while coding so that all corrections follow the same first word (like calculate_tide_correction)
  • After applying the butterworth filter, decimating_to_hourly instead of being applied directly to the timeseries object - I'm not sure why this is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant