Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Missing Favicon on the Website #11337

Closed
nitesh2920 opened this issue Oct 2, 2024 · 17 comments · Fixed by #11603
Closed

Issue: Missing Favicon on the Website #11337

nitesh2920 opened this issue Oct 2, 2024 · 17 comments · Fixed by #11603
Labels
PR requested Issues that can be addressed with a new PR

Comments

@nitesh2920
Copy link

nitesh2920 commented Oct 2, 2024

I noticed that the website currently does not have a favicon. A favicon is a small but important element that adds a more professional and polished look to the site. It also helps users quickly recognize the tab when multiple browser tabs are open.

I would like to suggest adding a favicon to the site.

If you're open to this improvement, I'd be happy to contribute by adding the favicon myself. Please let me know if you'd like me to proceed!

@eshellman
Copy link
Collaborator

I didn't realize you could do that. Use the EbookFoundation favicon

@eshellman eshellman added the PR requested Issues that can be addressed with a new PR label Oct 2, 2024
@nitesh2920
Copy link
Author

nitesh2920 commented Oct 3, 2024

Hi @eshellman,

I have a quick question regarding contributing to the website. I noticed that it's built using Jekyll, but I’m having trouble locating the index.md or home page to modify. Additionally, when I try to run the website locally, it doesn’t appear as it does in production.

Could you please guide me on how to:
Properly run the site locally so that it matches the live version.
Locate the main entry point (e.g., index.md or equivalent) for making contributions like adding a favicon.

@sarah-abeer
Copy link

please assign me this issue

@MZ-AD
Copy link

MZ-AD commented Oct 11, 2024

You can assign me this issue

@aggavni4
Copy link

where is the front-end code for the website?

@eshellman
Copy link
Collaborator

@Ayushgautam16
Copy link

please assign me this issue

@SaranshPrasad
Copy link

/assign

@azamshaikh1103
Copy link
Contributor

Hey @eshellman, Since the repo doesn’t have any assets folder or HTML files, what would be the best way to add a favicon? Should I create an assets folder or modify the markdown front matter?

@eshellman
Copy link
Collaborator

Ajay is trying it in #11603 Collaboration is highly encouraged here!

@Ajay-singh1
Copy link
Contributor

Ajay-singh1 commented Oct 19, 2024

@azamshaikh1103 Hey! You can check how to add a favicon from the minimal theme website here https://github.com/pages-themes/minimal. Also go through this PR #11603 maybe we can pair program:)

@azamshaikh1103
Copy link
Contributor

@azamshaikh1103 Hey! You can check how to add a favicon from the minimal theme website here https://github.com/pages-themes/minimal. Also go through this PR #11603 maybe we can pair program:)

Thanks for the response! I'll definitely check out the link and the PR to see how the minimal theme handles favicons. Pair programming sounds awesome—I'd love to collaborate on this! Let me dive into the resources, and I’ll reach out once I have a better understanding.

Looking forward to working together on this!

@azamshaikh1103
Copy link
Contributor

azamshaikh1103 commented Oct 20, 2024

image

@Ajay-singh1 Hey, I created new file head.html inside _includes folder and linked the favicon.ico
but I'm struggling to run this code.

can u pls help me run this code locally?

P.S, using a temp favicon, I'll change it

@Ajay-singh1
Copy link
Contributor

Ajay-singh1 commented Oct 21, 2024

@azamshaikh1103 To run this locally you need to have jekyll installed on your local system and some gem files then you run the jekyll server and you are good to go you can look for how to do it using AI tools like chatgpt etc.

This was referenced Oct 26, 2024
@azamshaikh1103
Copy link
Contributor

#11689 Mistakenly added the _static folder along with the Gemfile.

#11690 Added favicon.ico to the root folder. It's working, but the checks are failing - upload-artifact@v4

@Ajay-singh1
Copy link
Contributor

@azamshaikh1103 You need to include and _include folder in the repository and create a file head.html then just link the favicon their.

@mi6paulino
Copy link

IMG_9534
IMG_9533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR requested Issues that can be addressed with a new PR
Projects
None yet
10 participants