Added favicon to the website which will make the site look great.

[Ajay-singh1]

What does this PR do?

Improve repo

Description

Added favicon to the site which will make the site look great fixes #11337 I have tested the site locally through github pages and it works great :).I have added the ebookfoundation logo as the favicon.

Why is this valuable (or not)?

Yes it is very valuable

Checklist:

• Read our contributing guidelines.
• Search for duplicates.
• Include author(s) and platform where appropriate.
• Put lists in alphabetical order, correct spacing.
• Add needed indications (PDF, access notes, under construction).
• Used an informative name for this pull request.

Follow-up

• Check the status of GitHub Actions and resolve any reported warnings!

[Ajay-singh1]

[eshellman]

Hmmm, looks like this change breaks the build

[Ajay-singh1]

@eshellman Yes the build will break for this PR as I have added the favicon icon and nothing else.The site uses Jekyll theme and uses a remote theme from minimal so I just injected favicon in the headtag.What are your thoughts?

[eshellman]

Maybe you need to inject it from the free-programming-ebooks-search repo?

[Ajay-singh1]

@eshellman Okay I will do that.

[Thenlie]

The "Check URLs" actions are failing due to the file types of the changed files.

https://github.com/EbookFoundation/free-programming-books/blob/main/.github/workflows/check-urls.yml#L93 On this line we grab the file by getting all characters preceding a .md or .yml extension. The two files failing the check have a .html and .ico extension so this file name is blank. Because of this the upload artifact step fails.

Options for Resolution

1. Add the .ico and .html extension to that regex linked above, however that could cause issues as we don't actually want to "check URLs" for these file types.
2. Simply ignore the Check URLs step here as it is not relevant to these files.
3. Update the action to skip if the file extension is not .md or .yml. I think this is likely the best option.

cc: @eshellman

[Ajay-singh1]

@Thenlie Thanks for helping out here.

[Thenlie]

@Ajay-singh1 #11760 should get this working. Let me know if not!

[Ajay-singh1]

@eshellman We can cleanly merge this PR now.