Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Display Code of Conduct & License #229

Merged
merged 7 commits into from
Sep 30, 2022

Conversation

KlausMikhaelson
Copy link
Member

@KlausMikhaelson KlausMikhaelson commented Sep 22, 2022

Fixes Issue

Closes #204

Changes proposed

Check List (Check all the applicable boxes)

  • [ X] My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • [ X] All new and existing tests passed.
  • [ X] This PR does not contain plagiarized content.
  • [ X] The title of my pull request is a short description of the requested changes.

Screenshots

eddie solved

Note to reviewers

I am willing to make any changes if they are required ! this is my first pr for eddiehub community so thank you !

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🚀 In general it looks quite good, just some small comments:

The comments are always referring to the screenshot above them
grafik

  • The text in lightmode isn't readable
  • The badges aren't vertically centered (see badges next to them)

grafik

  • On mobile they take up too much space, I think that we should move the badges into the collapsable section where currently the labels are shown, just on mobile though, what do you think?

@KlausMikhaelson
Copy link
Member Author

Yeah sounds good will make the changes right away !
Thank you !

@KlausMikhaelson
Copy link
Member Author

Hey @Cahllagerfeld I have made all the changes accordingly please review it and lmk if there is something that I should change further. Thank you !

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are very close to getting it merged 🚀 Last small nit:

grafik

  • On mobile it would be better to have the labels display in the section next to the other labels, e.g. aspect-code, and not in the card header.

Other than that the changes look very good to me 👍

@KlausMikhaelson
Copy link
Member Author

I think we are very close to getting it merged 🚀 Last small nit:

grafik
  • On mobile it would be better to have the labels display in the section next to the other labels, e.g. aspect-code, and not in the card header.

Other than that the changes look very good to me 👍

Yeah that should be easy just give me few minutes will make those changes

@KlausMikhaelson
Copy link
Member Author

Hey @Cahllagerfeld I have made those changes do lmk if there's anything else to change !
Thank you !

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KlausMikhaelson 👋
I made a small adjustment to get rid of the custom breakpoints, as we can also use the tailwind ones + I extended the types so the typescript compiler is happy 🎉
We can get this merged now I think 🛹

@Cahllagerfeld Cahllagerfeld changed the title Added Badges Display Code of Conduct & License Sep 30, 2022
@Cahllagerfeld Cahllagerfeld merged commit c51ab21 into EddieHubCommunity:main Sep 30, 2022
@KlausMikhaelson
Copy link
Member Author

Awesome thank you so much for the help ! @Cahllagerfeld

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Show that it is a "friendly" repo
3 participants