Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Added filter modal #319

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

rprav-n
Copy link
Contributor

@rprav-n rprav-n commented Apr 8, 2023

Fixes Issue

Closes #215

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Video:

filter_modal.mp4

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Sorry for taking a while for review:
The only thing that I saw, is that the modal should also close when pressing the esc-button. Other than that its looking good to me 👍

@rprav-n
Copy link
Contributor Author

rprav-n commented Apr 15, 2023

@Cahllagerfeld Thanks.

Sorry for taking a while for review:

No worries.

modal should also close when pressing the esc-button

Sure, will do that.

@rprav-n
Copy link
Contributor Author

rprav-n commented Apr 15, 2023

@Cahllagerfeld

Added: On pressing esc-button the modal should close functionality.

Video:

close_modal.mov

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Cahllagerfeld Cahllagerfeld merged commit 0b4b885 into EddieHubCommunity:main Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Move Filters to Modal
3 participants