Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#390 #391

Merged
merged 1 commit into from
Sep 22, 2023
Merged

#390 #391

merged 1 commit into from
Sep 22, 2023

Conversation

sjpark608
Copy link
Collaborator

#390 handling cases and enforcing the current module state

handling cases and enforcing the current module state
@sjpark608 sjpark608 added bug Something isn't working DAC GPIO PWM labels Sep 21, 2023
@sjpark608 sjpark608 linked an issue Sep 21, 2023 that may be closed by this pull request
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
adc 92% 89%
calibration 100% 100%
dac 100% 97%
digital_input 100% 100%
digital_output 98% 95%
eeprom 83% 63%
eeprom.protobuf_assets.eeprom_data_classes 97% 52%
eeprom.protobuf_assets.generated_pb2 79% 50%
gpio 99% 96%
led 0% 0%
peripherals 93% 50%
pwm 99% 98%
reg_helper 97% 85%
relay 100% 100%
tc 98% 98%
utilities 100% 100%
Summary 93% (3087 / 3311) 82% (643 / 785)

Copy link
Collaborator

@farzadpanahi farzadpanahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjpark608 do you have a test that covers that specific case you solved?

@sjpark608
Copy link
Collaborator Author

@sjpark608 do you have a test that covers that specific case you solved?

Right now, unit tests perform whether set/clear GPIO pins with specific pin names are asserted or not. However, the the sequence of the execution is not tested

@sjpark608 sjpark608 merged commit 50aeaf9 into dev Sep 22, 2023
@sjpark608 sjpark608 deleted the dev-issue#390 branch September 22, 2023 17:36
@sjpark608 sjpark608 restored the dev-issue#390 branch September 22, 2023 17:38
@sjpark608 sjpark608 mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DAC GPIO PWM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAC setting to voltage 0 does not work
2 participants