Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Page Options when Changing Layout #2212

Closed
1 task done
jmxp69 opened this issue Aug 15, 2022 · 4 comments · Fixed by #2218 or #5530
Closed
1 task done

Retain Page Options when Changing Layout #2212

jmxp69 opened this issue Aug 15, 2022 · 4 comments · Fixed by #2218 or #5530
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour

Comments

@jmxp69
Copy link

jmxp69 commented Aug 15, 2022

Is there an existing issue for this feature request?

  • I have searched the existing issues

Is your feature request related to a problem?

This may be completely preempted with LVGL, but I'm going to ask anyway.

When changing the layout for a main view, the options Top Bar/Flight Mode/Sliders/Trims are reset. Can we please not change those just because the layout is adjusted? Very annoying while working with widget layouts.

Describe the solution you'd like

Do not change Top bar, Flight mode, Sliders, Trims state when layout is changed.

Describe alternatives you've considered

Ethos? :)

Additional context

No response

@jmxp69 jmxp69 added the enhancement ✨ New feature or request label Aug 15, 2022
@pfeerick
Copy link
Member

pfeerick commented Aug 15, 2022

Mere mention of Ethos could get this issue closed without resolution :-P

LVGL doesn't change anything here, as evidenced in the nighties. As the options are actually part of the layout (i.e. this is why the 2x4 layout has some extra options not present on any other layout) this may require some redesign of the layout system. I do agree it would be nice if they stayed as set if common to other layouts.

@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Aug 15, 2022
@jmxp69
Copy link
Author

jmxp69 commented Aug 16, 2022

While we're on this subject, I noticed on 2.7.1 if I switch to a telemetry page, long press the tele button, the page editor brings me to the page I had been viewing. On 2.8.x that behavior changes and the editor always goes to page 1. Long pressing the tele button to launch the page editor on the page being viewed is the correct behavior IMHO.

@jmxp69
Copy link
Author

jmxp69 commented Aug 16, 2022

Mere mention of Ethos could get this issue closed without resolution :-P

Just a little shock value to wake up the audience.

@pfeerick
Copy link
Member

While we're on this subject, I noticed on 2.7.1 if I switch to a telemetry page, long press the tele button, the page editor brings me to the page I had been viewing. On 2.8.x that behavior changes and the editor always goes to page 1. Long pressing the tele button to launch the page editor on the page being viewed is the correct behavior IMHO.

Yeah, that's a regression... earlier versions used to behave like 2.8 does now... and I think it was 2.7 that made it jump to the tab for the current view. Thanks for catching that.

Just a little shock value to wake up the audience.

More like showed signs of insanity even contemplating it... Ethos is pure evil since it's Frsky ... you know better! 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
2 participants