Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm v3 support? #159

Closed
mickaelandrieu opened this issue Jan 8, 2019 · 7 comments
Closed

Psalm v3 support? #159

mickaelandrieu opened this issue Jan 8, 2019 · 7 comments

Comments

@mickaelandrieu
Copy link

Hi!

I'd like to use Psalm v3 but for now it doesn't works, what can I do to add support of Psalm v3 (ideally with PHPUnit plugin) into phpqa?

Mickaël

Thanks for your awesome project ❤️

@zdenekdrahos
Copy link
Member

What doesn't work?
Psalm v3 should work in v1.20 (#157). Travis looks ok with psalm v3.0.7

screenshot from 2019-01-08 15 37 06

@mickaelandrieu
Copy link
Author

When I require phpqa I get 1.4.3 from Composer, I don't know why I have PHP 7.2 installled on my computer (ubuntu-like).

@mickaelandrieu
Copy link
Author

Ok problem solved, thanks !

@mickaelandrieu
Copy link
Author

mickaelandrieu commented Jan 9, 2019

Sorry for reopening, but looks like it doesn't works (at least using the docker image).

Any ideas?

https://travis-ci.com/PrestaShop/circuit-breaker/jobs/169267177#L631

This is my travis file => https://github.com/PrestaShop/circuit-breaker/blob/master/.travis.yml

Maybe it's because I don't use the "verbose" option? I will probably contribute a minimal travis.yml exemple file, because I'm pretty sure it's easy once you got the right configuration :)

@mickaelandrieu
Copy link
Author

mickaelandrieu commented Jan 9, 2019

Back again, and investigating on it, it looks like the ignoredDirs option is ... ignored.

https://travis-ci.com/PrestaShop/circuit-breaker/jobs/169270975#L857

@zdenekdrahos
Copy link
Member

Well, the docker image does not include latest versions.

travis build for php 7.0 uses same installation like docker image

You could build your own docker image with required versions. Or install phpqa via composer. Then you can install whatever version you like.

@mickaelandrieu
Copy link
Author

Yes, you're right :)

Thanks for your help, this time it's closed for sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants