Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs warnings should not be reported as errors #53

Closed
bblasius opened this issue Mar 24, 2017 · 2 comments
Closed

phpcs warnings should not be reported as errors #53

bblasius opened this issue Mar 24, 2017 · 2 comments

Comments

@bblasius
Copy link

phpcs warnings count as errors, exit with code 1 and break ci builds.

this could be avoided by changing the errorsXPath setting of phpcs.
change phpqa/src/CodeAnalysisTasks.php : 26 from "'errorsXPath' => '//checkstyle/file/error'" to "'errorsXPath' => '//checkstyle/file/error[@Severity="error"]'".

@zdenekdrahos
Copy link
Member

You are right, phpqa does not distinguish between errors and warnings.
I think that Jenkins does it too so I have never thought about it.

Would it be okay for you to set "ignore warnings" in .phpqa.yml?

@bblasius
Copy link
Author

an "ignore warnings" setting in .phpqa.yml would be absolutely fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants