Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): handle creation prompt defaults to yes #52

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

GabrielBrandao1618
Copy link
Contributor

As proposed in #51

@GabrielBrandao1618
Copy link
Contributor Author

GabrielBrandao1618 commented Jul 23, 2024

I also want to point something

image

The - special handle (that references the previous one) is no longer working somehow. I'm almost sure this wasn't caused by this PR, though

@EduardoRodriguesF
Copy link
Owner

Oh, thanks for reporting! I'll try to do a hotfix before merging this PR to master.

@GabrielBrandao1618
Copy link
Contributor Author

GabrielBrandao1618 commented Jul 25, 2024

Oh, thanks for reporting! I'll try to do a hotfix before merging this PR to master.

I figured what was causing this

// handle.rs
if let Ok(previous_handle) = StateField::PreviousEndpoint.get(ctx) {
    handle = previous_handle;
}

This was happening because of this if statement. If the previous-handle state field doesn't exist, that bug happens

I will open a PR fixing this

@EduardoRodriguesF EduardoRodriguesF merged commit dadb577 into EduardoRodriguesF:master Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants