Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wifi is restarted on the Oxide startup #110

Closed
Witos opened this issue Dec 10, 2020 · 5 comments · Fixed by #235
Closed

Wifi is restarted on the Oxide startup #110

Witos opened this issue Dec 10, 2020 · 5 comments · Fixed by #235
Assignees
Labels
Milestone

Comments

@Witos
Copy link
Contributor

Witos commented Dec 10, 2020

Describe the bug
Wifi goes down and then up on Oxide startup on RM2.

To Reproduce
Steps to reproduce the behavior:

  1. Start Oxide.

Expected behavior
Wifi shouldn't be disconnected

Screenshots
If applicable, add screenshots to help explain your problem.

Version Information:

  • Device: remarkable 2
  • OS: 2.4.1.30
  • Version af869c6

Additional context
Add any other context about the problem here.

@Witos Witos added bug Something isn't working to-triage This needs to be triaged labels Dec 10, 2020
@Eeems
Copy link
Collaborator

Eeems commented Dec 10, 2020

Just to clarify, wifi is already enabled and connected due to a previous run of tarnish?

@Witos
Copy link
Contributor Author

Witos commented Dec 10, 2020

Yes, I launch oxide via ash

@Eeems
Copy link
Collaborator

Eeems commented Dec 10, 2020

So tarnish wasn't running yet? Could you give me the full steps you use to reproduce this?

@Eeems Eeems changed the title [rm2] Wifi is restarted on the Oxide startup Wifi is restarted on the Oxide startup Dec 10, 2020
@Witos
Copy link
Contributor Author

Witos commented Dec 10, 2020

Attaching log for journalctl.
I'm starting it with:

  1. LD_PRELOAD=...server.so remarkable-shutdown
  2. systemctl stop xochitl
  3. systemctl start tarnish

[
boot.log
](url)

@Eeems
Copy link
Collaborator

Eeems commented Dec 10, 2020

Ah, so that makes complete sense. Since this is the first time tarnish has started, it needs to setup all the known networks for wpa_supplicant and requests that it connect to one of them.

Looks like we'd just need to tweak https://github.com/Eeems/oxide/blob/master/applications/system-service/wifiapi.h#L187-L204 to not call reconnect() if it's already connected and tarnish just hasn't determined this yet.

@Eeems Eeems added good first issue Good for newcomers help wanted Extra attention is needed 📱 reMarkable 1 and removed to-triage This needs to be triaged labels Dec 10, 2020
@Eeems Eeems mentioned this issue Jan 3, 2022
@Eeems Eeems removed the help wanted Extra attention is needed label Jan 3, 2022
@Eeems Eeems added this to the v2.3 milestone Jan 3, 2022
@Eeems Eeems closed this as completed in #235 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants