From 6efd9f342bfd93dc4a23206ef4dd86c4c779618d Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Sun, 19 Apr 2020 23:10:32 -0400 Subject: [PATCH] (clean): remove redundant tsconfig strict opts in tests (#690) - removed them in the templates in a previous commit, forgot to remove them in the tests too - presets would really help with this duplication / inconsistency problem - noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks, strictFunctionTypes, and strictPropertyInitialization are already enabled by strict, no need to configure them twice --- test/e2e/fixtures/build-default/tsconfig.json | 6 ------ test/e2e/fixtures/build-invalid/tsconfig.json | 6 ------ test/e2e/fixtures/build-withTsconfig/tsconfig.base.json | 6 ------ test/integration/fixtures/build-options/tsconfig.json | 6 ------ test/integration/fixtures/build-withBabel/tsconfig.json | 6 ------ test/integration/fixtures/build-withConfig/tsconfig.json | 6 ------ 6 files changed, 36 deletions(-) diff --git a/test/e2e/fixtures/build-default/tsconfig.json b/test/e2e/fixtures/build-default/tsconfig.json index 7f2bd50c5..50f2cc250 100644 --- a/test/e2e/fixtures/build-default/tsconfig.json +++ b/test/e2e/fixtures/build-default/tsconfig.json @@ -6,12 +6,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/test/e2e/fixtures/build-invalid/tsconfig.json b/test/e2e/fixtures/build-invalid/tsconfig.json index 7f2bd50c5..50f2cc250 100644 --- a/test/e2e/fixtures/build-invalid/tsconfig.json +++ b/test/e2e/fixtures/build-invalid/tsconfig.json @@ -6,12 +6,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/test/e2e/fixtures/build-withTsconfig/tsconfig.base.json b/test/e2e/fixtures/build-withTsconfig/tsconfig.base.json index 8197363fc..ab14e7936 100644 --- a/test/e2e/fixtures/build-withTsconfig/tsconfig.base.json +++ b/test/e2e/fixtures/build-withTsconfig/tsconfig.base.json @@ -8,12 +8,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/test/integration/fixtures/build-options/tsconfig.json b/test/integration/fixtures/build-options/tsconfig.json index a8c8432ed..8bbaebfc4 100644 --- a/test/integration/fixtures/build-options/tsconfig.json +++ b/test/integration/fixtures/build-options/tsconfig.json @@ -6,12 +6,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/test/integration/fixtures/build-withBabel/tsconfig.json b/test/integration/fixtures/build-withBabel/tsconfig.json index a8c8432ed..8bbaebfc4 100644 --- a/test/integration/fixtures/build-withBabel/tsconfig.json +++ b/test/integration/fixtures/build-withBabel/tsconfig.json @@ -6,12 +6,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, diff --git a/test/integration/fixtures/build-withConfig/tsconfig.json b/test/integration/fixtures/build-withConfig/tsconfig.json index a8c8432ed..8bbaebfc4 100644 --- a/test/integration/fixtures/build-withConfig/tsconfig.json +++ b/test/integration/fixtures/build-withConfig/tsconfig.json @@ -6,12 +6,6 @@ "sourceMap": true, "rootDir": "./src", "strict": true, - "noImplicitAny": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "strictPropertyInitialization": true, - "noImplicitThis": true, - "alwaysStrict": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true,