From 718306c7a5d9e9d6f135807a42d4163f26804805 Mon Sep 17 00:00:00 2001
From: Giulio Canti <giulio.canti@gmail.com>
Date: Thu, 22 Aug 2024 11:54:46 +0200
Subject: [PATCH] fix Array.replaceOption signature (#3497)

---
 packages/effect/dtslint/Array.ts | 44 ++++++++++++++++++++++++++++----
 packages/effect/src/Array.ts     |  6 ++---
 2 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/packages/effect/dtslint/Array.ts b/packages/effect/dtslint/Array.ts
index 9c6ddb0888..b29a5f03e8 100644
--- a/packages/effect/dtslint/Array.ts
+++ b/packages/effect/dtslint/Array.ts
@@ -1342,17 +1342,51 @@ Array.getSomes(hole<Iterable<Option.Option<number>> | Iterable<Option.Option<str
 // $ExpectType string[]
 Array.replace([], 0, "a")
 
-// $ExpectType ("a" | 1 | 2)[]
-Array.replace(new Set([1, 2] as const), 0, "a" as const)
+// $ExpectType (string | number)[]
+Array.replace(numbers, 0, "a")
 
 // $ExpectType [number | "a", ...(number | "a")[]]
-Array.replace(Array.of(1), 0, "a" as const)
+Array.replace(nonEmptyNumbers, 0, "a" as const)
+
+// $ExpectType ("a" | 1 | 2)[]
+Array.replace(new Set([1, 2] as const), 0, "a" as const)
 
 // $ExpectType string[]
 pipe([], Array.replace(0, "a"))
 
+// $ExpectType (string | number)[]
+pipe(numbers, Array.replace(0, "a"))
+
+// $ExpectType [number | "a", ...(number | "a")[]]
+pipe(nonEmptyNumbers, Array.replace(0, "a" as const))
+
 // $ExpectType ("a" | 1 | 2)[]
 pipe(new Set([1, 2] as const), Array.replace(0, "a" as const))
 
-// $ExpectType [number | "a", ...(number | "a")[]]
-pipe(Array.of(1), Array.replace(0, "a" as const))
+// -------------------------------------------------------------------------------------
+// replaceOption
+// -------------------------------------------------------------------------------------
+
+// $ExpectType Option<string[]>
+Array.replaceOption([], 0, "a")
+
+// $ExpectType Option<(string | number)[]>
+Array.replaceOption(numbers, 0, "a")
+
+// $ExpectType Option<[number | "a", ...(number | "a")[]]>
+Array.replaceOption(nonEmptyNumbers, 0, "a" as const)
+
+// $ExpectType Option<("a" | 1 | 2)[]>
+Array.replaceOption(new Set([1, 2] as const), 0, "a" as const)
+
+// $ExpectType Option<string[]>
+pipe([], Array.replaceOption(0, "a"))
+
+// $ExpectType Option<(string | number)[]>
+pipe(numbers, Array.replaceOption(0, "a"))
+
+// $ExpectType Option<[number | "a", ...(number | "a")[]]>
+pipe(nonEmptyNumbers, Array.replaceOption(0, "a" as const))
+
+// $ExpectType Option<("a" | 1 | 2)[]>
+pipe(new Set([1, 2] as const), Array.replaceOption(0, "a" as const))
diff --git a/packages/effect/src/Array.ts b/packages/effect/src/Array.ts
index 9d6e5f71b4..a8545f19e0 100644
--- a/packages/effect/src/Array.ts
+++ b/packages/effect/src/Array.ts
@@ -1049,7 +1049,7 @@ export const insertAt: {
  * import { Array } from "effect"
  *
  * const letters = ['a', 'b', 'c', 'd']
- * const result = Array.replace(1, 'z')(letters)
+ * const result = Array.replace(letters, 1, 'z')
  * assert.deepStrictEqual(result, ['a', 'z', 'c', 'd'])
  *
  * @since 2.0.0
@@ -1084,9 +1084,7 @@ export const replaceOption: {
   <B>(
     i: number,
     b: B
-  ): <A, S extends Iterable<A> = Iterable<A>>(
-    self: Iterable<A>
-  ) => Option<ReadonlyArray.With<S, ReadonlyArray.Infer<S> | B>>
+  ): <A, S extends Iterable<A> = Iterable<A>>(self: S) => Option<ReadonlyArray.With<S, ReadonlyArray.Infer<S> | B>>
   <A, B, S extends Iterable<A> = Iterable<A>>(
     self: S,
     i: number,