From 6c52d3825c160ea6849cd2f416f9462dd853c0c2 Mon Sep 17 00:00:00 2001 From: Tim Date: Tue, 11 Jun 2024 11:27:17 +1200 Subject: [PATCH] fix discard option in Effect.all --- .changeset/nervous-houses-explain.md | 5 +++++ packages/effect/src/internal/fiberRuntime.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/nervous-houses-explain.md diff --git a/.changeset/nervous-houses-explain.md b/.changeset/nervous-houses-explain.md new file mode 100644 index 0000000000..e8fe776d26 --- /dev/null +++ b/.changeset/nervous-houses-explain.md @@ -0,0 +1,5 @@ +--- +"effect": patch +--- + +fix discard option in Effect.all diff --git a/packages/effect/src/internal/fiberRuntime.ts b/packages/effect/src/internal/fiberRuntime.ts index 96d204ae60..fef56bbe98 100644 --- a/packages/effect/src/internal/fiberRuntime.ts +++ b/packages/effect/src/internal/fiberRuntime.ts @@ -1826,7 +1826,7 @@ export const all = < return allEither(effects, reconcile, options) as any } - return reconcile._tag === "Some" + return options?.discard !== true && reconcile._tag === "Some" ? core.map( forEach(effects, identity, options as any), reconcile.value