From e6525824ab0e94110e73a3573331dd702a5d3e6c Mon Sep 17 00:00:00 2001
From: Rishab Motwani <rmotwani-c@eightfold.ai>
Date: Tue, 20 Aug 2024 23:29:07 +0530
Subject: [PATCH] a11y: Fixed nested interactive element issue by removing role
 button from drag and drop zone (#873)

* fix: uploadDropzone: Fixed nested interactive element issue by removing role button from DragZone

* fix: uploadDropZone: Updated test case

---------

Co-authored-by: Jeff Howard <106610186+jhoward-eightfold@users.noreply.github.com>
---
 src/components/Upload/Internal/AjaxUploader.tsx              | 2 +-
 .../Upload/Tests/__snapshots__/uploadlist.test.tsx.snap      | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/components/Upload/Internal/AjaxUploader.tsx b/src/components/Upload/Internal/AjaxUploader.tsx
index 1af80f2e6..2a029b393 100644
--- a/src/components/Upload/Internal/AjaxUploader.tsx
+++ b/src/components/Upload/Internal/AjaxUploader.tsx
@@ -313,7 +313,7 @@ class AjaxUploader extends Component<OcUploadProps> {
           onDragOver: this.onFileDrop,
         };
     return (
-      <Tag {...events} className={uploadClasses} role="button" style={style}>
+      <Tag {...events} className={uploadClasses} style={style}>
         <input
           {...pickAttrs(rest, { aria: true, data: true })}
           id={id}
diff --git a/src/components/Upload/Tests/__snapshots__/uploadlist.test.tsx.snap b/src/components/Upload/Tests/__snapshots__/uploadlist.test.tsx.snap
index e01f78cd8..8a06be168 100644
--- a/src/components/Upload/Tests/__snapshots__/uploadlist.test.tsx.snap
+++ b/src/components/Upload/Tests/__snapshots__/uploadlist.test.tsx.snap
@@ -78,7 +78,6 @@ exports[`Upload List should be uploading when upload a file 1`] = `
   >
     <span
       class=""
-      role="button"
     >
       <input
         accept=""
@@ -190,7 +189,6 @@ exports[`Upload List should non-image format file preview 1`] = `
   >
     <span
       class=""
-      role="button"
     >
       <input
         accept=""
@@ -893,7 +891,6 @@ exports[`Upload List should support removeIcon, replaceIcon, and downloadIcon 1`
   >
     <span
       class=""
-      role="button"
     >
       <input
         accept=""
@@ -1094,7 +1091,6 @@ exports[`Upload List should support removeIcon, replaceIcon, and downloadIcon 2`
   >
     <span
       class=""
-      role="button"
     >
       <input
         accept=""
@@ -1295,7 +1291,6 @@ exports[`Upload List should support showRemoveIconButton, showReplaceButton, and
   >
     <span
       class=""
-      role="button"
     >
       <input
         accept=""