Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input: fixes rectangle shape for theme 2 input and textarea #295

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

This changes to make pill the default shape regressed the default rectangle shape in css. This change reverts the regression and updates the radius to map to theme 2.

JIRA TASK (Eightfold Employees Only):

ENG-26634

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the pr branch and run yarn, then yarn storybook, then verify the change in Input stories - or use CodeSandbox CI and implement a TextInput and TextArea with shape={TextInputShape.Rectangle}

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1dda75f:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@54b6418). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage        ?   88.38%           
=======================================
  Files           ?      385           
  Lines           ?    10421           
  Branches        ?     3523           
=======================================
  Hits            ?     9211           
  Misses          ?     1190           
  Partials        ?       20           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ychhabra-eightfold ychhabra-eightfold merged commit 658d009 into EightfoldAI:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants