fix: select: fixes pills layout and removes redundant options change #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redundant options change was triggering a second onClick event with no value
dkilgore-eightfold
requested review from
ychhabra-eightfold,
jhoward-eightfold and
atapshalkar-eightfold
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1623136:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage ? 88.53%
=======================================
Files ? 400
Lines ? 10754
Branches ? 3639
=======================================
Hits ? 9521
Misses ? 1210
Partials ? 23 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jhoward-eightfold
approved these changes
Aug 23, 2022
ychhabra-eightfold
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
The redundant options change was triggering a second onClick event with no value, recent changes to the Dropdown component remove the need to do this.
selectFixup.mp4
JIRA TASK (Eightfold Employees Only):
ENG-27401
CHANGE TYPE:
TEST PLAN:
pull the pr changes and run
yarn, thenyarn storybook, verify the changes in the Select stories and this component behaves as expected.