Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rtl: rtl ui polish #387

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • RTL UI polish of existing Octuple components, fixes most RTL bugs, adds all missing RTL support.
  • Fixes a few other minor bugs
  • Fixes a bug where the Table header border radius causes scrollable table rows to be visible on top corners

JIRA TASK (Eightfold Employees Only):

ENG-30033
ENG-29153

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

TODO: Add basic tests to ensure top-level rtl clases have been added

TEST PLAN:

Pull the pr branch and do yarn and yarn storybook. Verify all stories behave as expected when the document dir="rtl".

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 55aef43:

Sandbox Source
React Configuration
Vanilla Configuration

@dkilgore-eightfold dkilgore-eightfold merged commit 5eb44e9 into EightfoldAI:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants