feat: table: Add loc support and column, cell css vertical alignment prop #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Adds loc support to Table whilst preserving custom strings via props
Adds verticalAlign prop to
Column
andCell
GITHUB ISSUE (Open Source Contributors)
#374
JIRA TASK (Eightfold Employees Only):
ENG-30680
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the pr branch and do
yarn
, thenyarn storybook
, verify the Table stories behave as expected.Set the Table locale to another language and test the sort tooltip as follows (pseudo-code):
The ascending tooltip text should read 'foo' and the others should use the loc defaults
Test the column/cell vertical alignment as follows (pseudo-code):