Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable readOnly for pills without buttons #396

Merged
merged 5 commits into from
Sep 29, 2022
Merged

feat: Enable readOnly for pills without buttons #396

merged 5 commits into from
Sep 29, 2022

Conversation

szhang-eightfold
Copy link
Contributor

@szhang-eightfold szhang-eightfold commented Sep 28, 2022

SUMMARY:

Enable readOnly for pills when buttons are present

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/jira/software/c/projects/ENG/boards/50?modal=detail&selectedIssue=ENG-30670

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • go to storybook's Pill component canvas
  • In default Pills and Pills with icon sections
  • check that they are not hoverable and no hover effect are implemented
  • switch to other sections (with buttons)
  • check that they are hoverable and have hover effects

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a211a5:

Sandbox Source
React Configuration
Vanilla Configuration

@szhang-eightfold szhang-eightfold changed the title fix: add readOnly to Pill feat: add readOnly to Pill Sep 28, 2022
src/components/Pills/Pill.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@d363abb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage        ?   84.49%           
=======================================
  Files           ?      519           
  Lines           ?    13546           
  Branches        ?     4614           
=======================================
  Hits            ?    11446           
  Misses          ?     2060           
  Partials        ?       40           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@szhang-eightfold szhang-eightfold changed the title feat: add readOnly to Pill feat: Enable readOnly for pills without buttons Sep 29, 2022
@szhang-eightfold szhang-eightfold merged commit 66954ef into EightfoldAI:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants